Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove required nearby devices permission for calling (WPB-4583) #2460

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 23, 2023

TaskWPB-4583 [Android] Enable joining a call without giving permissions to nearby devices


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Nearby devices permission is required to make calls on Wire.

Causes (Optional)

After the behaviour changes that Google done on Android 12(>= API 31), nearby devices permission is required when connecting to BT devices.

Solutions

Refactor is done on AVS, on Android we just need to remove the logic to request BT permission

Dependencies (Optional)

Needs to be merged with wireapp/kalium#2257

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, yamilmedina, borichellow, MohamadJaara and mchenani and removed request for a team November 23, 2023 13:39
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #2460 (5bb2520) into develop (8fed4bf) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2460      +/-   ##
=============================================
+ Coverage      40.96%   40.97%   +0.01%     
  Complexity      1096     1096              
=============================================
  Files            348      348              
  Lines          12714    12710       -4     
  Branches        1658     1656       -2     
=============================================
  Hits            5208     5208              
+ Misses          7020     7016       -4     
  Partials         486      486              
Files Coverage Δ
...id/ui/home/conversationslist/ConversationRouter.kt 0.00% <ø> (ø)
...d/util/permission/CallingRecordAudioRequestFlow.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fed4bf...5bb2520. Read the comment docs.

@AndroidBob
Copy link
Collaborator

Build 1956 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Nov 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 23, 2023
@ohassine ohassine enabled auto-merge November 24, 2023 08:04
@ohassine ohassine added this pull request to the merge queue Nov 24, 2023
Merged via the queue into develop with commit 8dd2521 Nov 24, 2023
10 checks passed
@ohassine ohassine deleted the remove_nearby_devices_permission_for_calling branch November 24, 2023 08:36
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1974 succeeded.

The build produced the following APK's:

MohamadJaara added a commit that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants