fix: app lock dialog blinking (WPB-5610) #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge with a Launched effect
alexandreferris
requested review from
a team,
yamilmedina,
borichellow,
MohamadJaara,
mchenani and
ohassine
and removed request for
a team
|
Build 1964 succeeded. The build produced the following APK's: |
mchenani
approved these changes
Nov 24, 2023
MohamadJaara
approved these changes
Nov 24, 2023
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1983 succeeded. The build produced the following APK's: |
5 tasks
|
APKs built during tests are available here. Scroll down to Artifacts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
AppLock Dialog was blinking when being enabled/disabled when on a second account.
Causes (Optional)
The observer for loading current user and its changes was not being propagated correctly due to it only being activated when we needed to do another sync (e.g.: app close then open)
Solutions
As decided with @MohamadJaara we will only be showing the app lock dialog on the said account itself (not on other accounts that are logged in on the device).
We did two things:
Create a currentUserId variable in the view model to be updated whenever there is a change and listen to this change on a
LaunchedEffecton the UI so it reloads the initial sync needed to show/hide the dialogs.Dependencies (Optional)
Needs releases with:
Testing
How to Test