Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: closing keyboard or back pressing when editing a message #2467

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

AndroidBob
Copy link
Collaborator

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When during a message edit, if user hides a keyboard or pressed back button then composer ends up in a wrong state where + button is available but it's still in editing mode.

Solutions

Do not show + button when editing, even if keyboard is closed and handle back press to close editing mode.

Testing

How to Test

Open conversation, start editing a message and close keyboard or press back.

Attachments (Optional)

Before After
edit_back_before.mp4
edit_back_after.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Nov 24, 2023
Copy link
Contributor

github-actions bot commented Nov 24, 2023

Test Results

694 tests  ±0   694 ✔️ ±0   6m 24s ⏱️ -19s
  98 suites ±0       0 💤 ±0 
  98 files   ±0       0 ±0 

Results for commit e969e55. ± Comparison against base commit 8dd2521.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk requested review from a team, typfel, alexandreferris, vitorhugods, Garzas and saleniuk and removed request for a team November 24, 2023 10:41
@AndroidBob
Copy link
Collaborator Author

Build 1981 succeeded.

The build produced the following APK's:

@saleniuk saleniuk added this pull request to the merge queue Nov 24, 2023
Merged via the queue into develop with commit 2d9a304 Nov 24, 2023
11 checks passed
@saleniuk saleniuk deleted the fix/message-editing-back-press-cherry-pick branch November 24, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants