Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable back press when app lock team enforced (WPB-5644) #2474

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Nov 27, 2023

BugWPB-5644 [Android] Back button bypasses applock screen when it is forced


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When AppLock is enforced by team, it was able to press back button (either hardware or app button) and navigate back in the screen and use the app normally until next closing/opening app and being prompted with setting app lock password.

Solutions

When AppLock is enforced by team, hide back button on app and disable back button on screen.
Functionalities remain the same when it is not enforced by team but user wants to set AppLock.

Testing

How to Test

  • Open App
  • Receive AppLock enforced by team dialog
  • on Set AppLock password screen
  • make sure back button is hidden (top left) + hardware back button has no effect.

Copy link
Contributor

github-actions bot commented Nov 27, 2023

Test Results

696 tests   696 ✔️  8m 41s ⏱️
  99 suites      0 💤
  99 files        0

Results for commit 0bb28ee.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2028 failed.

@AndroidBob
Copy link
Collaborator

Build 2037 failed.

@AndroidBob
Copy link
Collaborator

Build 2057 failed.

@AndroidBob
Copy link
Collaborator

Build 2058 failed.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 28, 2023
@alexandreferris alexandreferris enabled auto-merge (squash) November 28, 2023 12:15
@AndroidBob
Copy link
Collaborator

Build 2073 failed.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@alexandreferris alexandreferris merged commit 1eef352 into release/candidate Nov 28, 2023
8 checks passed
@alexandreferris alexandreferris deleted the fix/disable_back_press_when_app_lock_team_enforced branch November 28, 2023 13:07
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants