Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide search button in group conversation user profile [WPB-5656] #2476

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix: hide search button in group conversation user profile [WPB-5656] #2476

merged 1 commit into from
Nov 27, 2023

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Nov 27, 2023 •
edited by github-actions bot
Loading

BugWPB-5656 [Android][Search] Hide search button when entering user profile from Group Participants

Cherry pick from the original PR:

⚠️ Conflicts during cherry-pick:

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • fixed showing search button when opening user profile from group details (it will check if state contains groupInfo)

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Nov 27, 2023
alexandreferris
alexandreferris approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻👏🏻

@Garzas Garzas enabled auto-merge November 27, 2023 13:50
@Garzas Garzas added this pull request to the merge queue Nov 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

Test Results

695 tests  ±0   695 ✔️ ±0   10m 28s ⏱️ + 3m 58s
  98 suites ±0       0 💤 ±0 
  98 files   ±0       0 ❌ ±0 

Results for commit e288591. ± Comparison against base commit e78f845.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 36fd8d6 Nov 27, 2023
9 of 10 checks passed
@Garzas Garzas deleted the fix/hide-search-group-conv-user-profile-cherry-pick branch November 27, 2023 14:17
@AndroidBob
Copy link
Collaborator Author

Build 2042 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchenani mchenani mchenani approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@saleniuk saleniuk Awaiting requested review from saleniuk

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

Assignees

@Garzas Garzas

Labels
cherry-pick PR is cherry-picking changes from another banch size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndroidBob @alexandreferris @mchenani @Garzas