fix: app not locked after timeout when screen turned off [WPB-5682] [WPB-5832] #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2259 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
ohassine
reviewed
Dec 13, 2023
app/src/main/kotlin/com/wire/android/ui/home/appLock/LockCodeTimeManager.kt
Show resolved
Hide resolved
8 tasks
saleniuk
requested review from
ohassine,
a team,
typfel,
borichellow,
MohamadJaara and
Garzas
and removed request for
a team
ohassine
approved these changes
Dec 13, 2023
MohamadJaara
approved these changes
Dec 13, 2023
|
Build 2260 succeeded. The build produced the following APK's: |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When the device's screen is being turned off, the app is not locked when the app lock is on.
Causes (Optional)
We use
delayto emit locked state after given timeout, but when the device is turned off, it goes into "doze" mode and it disrupts thedelayso that it can take way longer than it should:Solutions
In addition also keep the timestamp and compare it when putting app back into foreground.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Turn app lock on, put the app into background and turn off the screen (phone should not be plugged in and charging), turn it on and open the app after the app lock timeout.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.