Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allowed username characters [WPB-4365] #2519

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Dec 12, 2023

StoryWPB-4365 [Android] Allowed username characters


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Android only allows a-z, 0-9, “” when creating or updating user handle but the user should be allowed to use a-z, 0-9, “”, “-”, “.”.

Solutions

Update strings to include these allowed characters and use changes from kalium for verifying the user handle.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Try to create or update user handle with these characters.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

Test Results

726 tests  ±0   726 ✔️ ±0   11m 23s ⏱️ +58s
100 suites ±0       0 💤 ±0 
100 files   ±0       0 ±0 

Results for commit 37fba4c. ± Comparison against base commit 83bf0f3.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2256 succeeded.

The build produced the following APK's:

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, alexandreferris, borichellow and Garzas and removed request for a team December 13, 2023 08:33
@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 13, 2023
Merged via the queue into develop with commit 1bfd772 Dec 13, 2023
16 checks passed
@MohamadJaara MohamadJaara deleted the fix/user-handle-allowed-characters branch December 13, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants