Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI bug in E2EI (WPB-5757, WPD-5758) #2522

Merged
merged 10 commits into from
Dec 28, 2023
Merged

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 13, 2023

Sub-taskWPB-5757 Update E2EI/MLS texts based on Figma


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@borichellow borichellow added the WIP Work In Progress label Dec 13, 2023
@borichellow borichellow self-assigned this Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (d141853) 41.16% compared to head (b35382f) 41.14%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2522      +/-   ##
=============================================
- Coverage      41.16%   41.14%   -0.02%     
  Complexity      1134     1134              
=============================================
  Files            361      361              
  Lines          13160    13165       +5     
  Branches        1733     1734       +1     
=============================================
  Hits            5417     5417              
- Misses          7216     7221       +5     
  Partials         527      527              
Files Coverage Δ
...e/android/ui/home/conversations/model/UIMessage.kt 47.16% <0.00%> (-0.62%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d141853...b35382f. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Test Results

738 tests  ±0   738 ✅ ±0   8m 51s ⏱️ +15s
102 suites ±0     0 💤 ±0 
102 files   ±0     0 ❌ ±0 

Results for commit b35382f. ± Comparison against base commit d141853.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2276 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2289 succeeded.

The build produced the following APK's:

@borichellow borichellow removed the WIP Work In Progress label Dec 14, 2023
@borichellow borichellow changed the title [WIP] fix: UI bug in E2EI (WPB-5757, WPD-5758) fix: UI bug in E2EI (WPB-5757, WPD-5758) Dec 14, 2023
@borichellow borichellow requested review from saleniuk, alexandreferris, mchenani and ohassine and removed request for saleniuk December 14, 2023 11:49
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2296 succeeded.

The build produced the following APK's:

@mchenani mchenani enabled auto-merge December 20, 2023 09:21
@AndroidBob
Copy link
Collaborator

Build 2387 failed.

@AndroidBob
Copy link
Collaborator

Build 2406 failed.

@mchenani mchenani added this pull request to the merge queue Dec 28, 2023
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 1ff4f2e Dec 28, 2023
13 checks passed
@mchenani mchenani deleted the fix/ui_bugs_in_e2ei branch December 28, 2023 15:11
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Sep 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 41.14%. Comparing base (d141853) to head (b35382f).
Report is 493 commits behind head on develop.

Files with missing lines Patch % Lines
...e/android/ui/home/conversations/model/UIMessage.kt 0.00% 8 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2522      +/-   ##
=============================================
- Coverage      41.16%   41.14%   -0.02%     
  Complexity      1134     1134              
=============================================
  Files            361      361              
  Lines          13160    13165       +5     
  Branches        1733     1734       +1     
=============================================
  Hits            5417     5417              
- Misses          7216     7221       +5     
  Partials         527      527              
Files with missing lines Coverage Δ
...e/android/ui/home/conversations/model/UIMessage.kt 47.16% <0.00%> (-0.62%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d141853...b35382f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants