Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong url for conversation creation in conflicting backends case (WPB-5014) #2524

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 13, 2023

BugWPB-5014 [Android] Wrong "Learn more" link from message in can not create group alert


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Wrong link to support due to federated conflicting domains.

Causes (Optional)

N/A.

Solutions

Fix it according to mocks.

Attachments (Optional)

Screenshot 2023-12-13 at 18 00 46

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Dec 13, 2023
@yamilmedina yamilmedina requested review from a team, typfel, alexandreferris, borichellow, MohamadJaara, Garzas and saleniuk and removed request for a team December 13, 2023 17:02
@yamilmedina yamilmedina changed the title fix: string for conversation creation for conflicting backends (WPB-5014) fix: wrong url for conversation creation in conflicting backends case (WPB-5014) Dec 13, 2023
Copy link
Contributor

Test Results

733 tests  ±0   733 ✔️ ±0   10m 2s ⏱️ - 1m 23s
101 suites ±0       0 💤 ±0 
101 files   ±0       0 ±0 

Results for commit a72d432. ± Comparison against base commit a6490b1.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2292 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Dec 14, 2023
Merged via the queue into develop with commit 862344d Dec 14, 2023
16 checks passed
@yamilmedina yamilmedina deleted the fix/wrong-federation-support-link branch December 14, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants