Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dialog for max accounts reached (WPB-1862) #2526

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 14, 2023

BugWPB-1862 Alert for maximum number of accounts reached for bund builds should say that only 2 accounts are allowed


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Dialog for max accounts had a fixed number of 3.

Causes (Optional)

Not taking into consideration custom build parameters from default.json / BuildConfig

Solutions

  • Remove duplicated dialog and reuse one component for it usage
  • Change strings to plurals to take into consideration parametrized value

Attachments (Optional)

Screenshot 2023-12-14 at 15 11 28


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested review from a team, typfel, borichellow, MohamadJaara, Garzas, ohassine, alexandreferris and saleniuk and removed request for a team December 14, 2023 14:23
Copy link
Contributor

Test Results

733 tests  ±0   733 ✔️ ±0   9m 57s ⏱️ + 2m 32s
101 suites ±0       0 💤 ±0 
101 files   ±0       0 ±0 

Results for commit b6412ee. ± Comparison against base commit 862344d.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2299 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Dec 14, 2023
Merged via the queue into develop with commit a40f950 Dec 14, 2023
14 checks passed
@yamilmedina yamilmedina deleted the fix/dialog-formax-accounts branch December 14, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants