fix: Remove reportDrawnWhen api due to crash on Android 9 #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2320 succeeded. The build produced the following APK's: |
yamilmedina
approved these changes
Dec 18, 2023
yamilmedina
requested review from
a team,
typfel,
alexandreferris,
borichellow,
Garzas and
ohassine
and removed request for
a team
alexandreferris
approved these changes
Dec 18, 2023
|
APKs built during tests are available here. Scroll down to Artifacts! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Build 2359 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Build 2367 failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
kalium
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
which used to improve app startup is causing some crashes on Samsung devices running on Android 9
There is ticket created on issueTracker, it's still in progress : https://issuetracker.google.com/issues/316294709.
For now we are just going to remove it.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References