Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: location replies (WPB-5480) #2534

Merged
merged 12 commits into from
Dec 19, 2023
Merged

feat: location replies (WPB-5480) #2534

merged 12 commits into from
Dec 19, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 15, 2023

StoryWPB-5480 [Android] Replies to Location - UI reply and display replies to location messages


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Location replies needs development so users can reply and visualize location replies.

Causes (Optional)

Not implemented.

Solutions

Implement the quoted/replies messages of location.

Depends on

Attachments

Screen.Recording.2023-12-15.at.16.26.10.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested a review from a team December 15, 2023 15:27
@yamilmedina yamilmedina self-assigned this Dec 15, 2023
@yamilmedina yamilmedina requested review from typfel, alexandreferris, borichellow, MohamadJaara and Garzas and removed request for a team December 15, 2023 15:27
Copy link
Contributor

github-actions bot commented Dec 15, 2023

Test Results

733 tests  ±0   733 ✔️ ±0   5m 49s ⏱️ - 4m 52s
101 suites ±0       0 💤 ±0 
101 files   ±0       0 ±0 

Results for commit 64bc703. ± Comparison against base commit a9547fc.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2325 failed.

@yamilmedina yamilmedina requested a review from ohassine December 18, 2023 14:45
Copy link
Contributor

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
a1d587fe94c683eaa86d31337654cce6a1f99834 6ad3f47301e2ff2bc273da5dbcf7b3087fb844a7

Is this intentional?

@AndroidBob
Copy link
Collaborator

Build 2336 failed.

Copy link
Contributor

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
a1d587fe94c683eaa86d31337654cce6a1f99834 6ad3f47301e2ff2bc273da5dbcf7b3087fb844a7

Is this intentional?

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #2534 (d9fc02c) into develop (a9547fc) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head d9fc02c differs from pull request most recent head 64bc703. Consider uploading reports for the commit 64bc703 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2534      +/-   ##
=============================================
- Coverage      41.08%   41.07%   -0.01%     
  Complexity      1118     1118              
=============================================
  Files            358      358              
  Lines          13095    13090       -5     
  Branches        1709     1711       +2     
=============================================
- Hits            5380     5377       -3     
+ Misses          7207     7205       -2     
  Partials         508      508              
Files Coverage Δ
...id/ui/home/conversations/messages/QuotedMessage.kt 0.00% <ø> (ø)
...wire/android/mapper/RegularMessageContentMapper.kt 22.51% <0.00%> (-0.16%) ⬇️
...e/android/ui/home/conversations/model/UIMessage.kt 48.15% <0.00%> (-0.13%) ⬇️
.../messagecomposer/state/MessageCompositionHolder.kt 32.12% <0.00%> (-0.30%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9547fc...64bc703. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2346 succeeded.

The build produced the following APK's:

Copy link
Contributor

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
a1d587fe94c683eaa86d31337654cce6a1f99834 ed692e172d11550a7b38d71a1144201c7e7dc8b6

Is this intentional?

@yamilmedina yamilmedina added this pull request to the merge queue Dec 19, 2023
@AndroidBob
Copy link
Collaborator

Build 2351 failed.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit c0aa6b9 Dec 19, 2023
12 of 13 checks passed
@yamilmedina yamilmedina deleted the feat/location-replies branch December 19, 2023 09:41
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants