Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notify user when sending first message in conversation on legal hold [WPB-4566] #2535

Merged
merged 9 commits into from
Dec 20, 2023

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Dec 15, 2023

StoryWPB-4566 [Android] Warn users before sending a message in a conversation on LH


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

When user opens a conversation with a team member on legal hold and wants to send first message after this conversation became subject to legal hold then he/she needs to be informed about that.

Implemented logic of observing and showing proper dialog when required.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Enable legal hold for one member and try to send a message.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Test Results

736 tests  +3   736 ✔️ +3   10m 6s ⏱️ +28s
101 suites ±0       0 💤 ±0 
101 files   ±0       0 ±0 

Results for commit e59e579. ± Comparison against base commit 2871638.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (2871638) 41.04% compared to head (e59e579) 41.11%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2535      +/-   ##
=============================================
+ Coverage      41.04%   41.11%   +0.07%     
- Complexity      1118     1126       +8     
=============================================
  Files            358      358              
  Lines          13108    13121      +13     
  Branches        1712     1716       +4     
=============================================
+ Hits            5380     5395      +15     
+ Misses          7220     7215       -5     
- Partials         508      511       +3     
Files Coverage Δ
.../ui/home/conversations/MessageComposerViewState.kt 87.50% <100.00%> (+1.78%) ⬆️
.../ui/home/conversations/MessageComposerViewModel.kt 81.00% <80.70%> (+1.52%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2871638...e59e579. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2326 succeeded.

The build produced the following APK's:

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, alexandreferris, mchenani and ohassine and removed request for a team December 15, 2023 17:09
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2400 succeeded.

The build produced the following APK's:

@saleniuk saleniuk added this pull request to the merge queue Dec 20, 2023
Merged via the queue into develop with commit d2f867e Dec 20, 2023
15 checks passed
@saleniuk saleniuk deleted the feat/notify-about-legal-hold-when-sending-msg branch December 20, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants