Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show verification icons in Calls flow (WPB-5792) #2537

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 18, 2023

BugWPB-5792 [Android] Verified shield not shown during ongoing call in calling UI

What's new in this PR?

Issues

Icon about verification status of conversation should be shown in Ongoing call, Incoming call and Initializing call screens.
But it is not.

Causes (Optional)

It wasn't described in the design.

Solutions

Add it there :)

Attachments (Optional)

Screenshot 2023-12-18 at 16 29 30 Screenshot 2023-12-18 at 16 29 09 Screenshot 2023-12-18 at 16 29 20

Copy link
Contributor

github-actions bot commented Dec 18, 2023

Test Results

733 tests  ±0   733 ✔️ ±0   7m 33s ⏱️ - 4m 7s
101 suites ±0       0 💤 ±0 
101 files   ±0       0 ±0 

Results for commit b772a3d. ± Comparison against base commit aaa2d87.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #2537 (b772a3d) into develop (aaa2d87) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2537      +/-   ##
=============================================
- Coverage      41.08%   41.08%   -0.01%     
  Complexity      1118     1118              
=============================================
  Files            358      358              
  Lines          13086    13095       +9     
  Branches        1709     1709              
=============================================
+ Hits            5377     5380       +3     
- Misses          7201     7207       +6     
  Partials         508      508              
Files Coverage Δ
...in/kotlin/com/wire/android/ui/calling/CallState.kt 100.00% <100.00%> (ø)
.../wire/android/ui/calling/SharedCallingViewModel.kt 64.16% <0.00%> (-2.31%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa2d87...b772a3d. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2335 succeeded.

The build produced the following APK's:

@borichellow borichellow added this pull request to the merge queue Dec 19, 2023
Merged via the queue into develop with commit a9547fc Dec 19, 2023
14 checks passed
@borichellow borichellow deleted the fix/show_verifcation_icons_in_calls_flow branch December 19, 2023 08:49
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants