-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: applock toggle state when enforced and responding to changes [WPB-5751] #2566
fix: applock toggle state when enforced and responding to changes [WPB-5751] #2566
Conversation
Build 2455 failed. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2566 +/- ##
=============================================
- Coverage 41.24% 41.23% -0.02%
Complexity 1138 1138
=============================================
Files 361 361
Lines 13190 13191 +1
Branches 1739 1741 +2
=============================================
- Hits 5440 5439 -1
- Misses 7219 7221 +2
Partials 531 531
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2457 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2474 succeeded. The build produced the following APK's: |
…-and-observing-updates-cherry-pick
…-updates-cherry-pick' into fix/applock-toggle-and-observing-updates-cherry-pick
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2477 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
app/src/main/kotlin/com/wire/android/ui/home/appLock/set/SetLockScreenViewModel.kt
app/src/test/kotlin/com/wire/android/ui/home/appLock/set/SetLockScreenViewModelTest.kt
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Currently, the app lock toggle is visible with ON value but just disabled when the app lock is enforced by the team admin. According to the designs in that case the toggle should be hidden and only ON text should be visible.
Also when the user is on that screen and the team admin changes the setting, it doesn't get updated automatically but only after closing and opening it again.
Solutions
Change the appearance of the app lock row so that if it's enforced by the team admin then the toggle is not shown but just a text is visible.
Use the updated use case to observe the editable app lock value changes instead of getting just a single value.
Dependencies (Optional)
Needs releases with:
Testing
How to Test
Open settings screen and change the app lock team settings on team admin panel.
Attachments (Optional)
applock_toggle_changes.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References