-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sharing location crash when device location off (dev) (WPB-6182) #2606
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2606 +/- ##
=============================================
- Coverage 41.33% 41.27% -0.07%
Complexity 1140 1140
=============================================
Files 365 365
Lines 13237 13257 +20
Branches 1749 1751 +2
=============================================
Hits 5472 5472
- Misses 7238 7258 +20
Partials 527 527
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2677 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When runtime (or device) permissions are turned off the app crashes.
Causes (Optional)
Runtime permissions not handled
Solutions
Handle and display error if device location is turned off.
Testing
Test Coverage (Optional)
How to Test
Turn device settings off, try to share your location, the app should not crash.
Attachments (Optional)
Screen.Recording.2024-01-22.at.10.44.14.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.