Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sharing location crash when device location off (dev) (WPB-6182) #2606

Merged
merged 10 commits into from
Jan 23, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 22, 2024

BugWPB-6182 [Android] When location is off, if user tries to share location app crashes


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When runtime (or device) permissions are turned off the app crashes.

Causes (Optional)

Runtime permissions not handled

Solutions

Handle and display error if device location is turned off.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Turn device settings off, try to share your location, the app should not crash.

Attachments (Optional)

Screen.Recording.2024-01-22.at.10.44.14.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina added the cherry-pick PR is cherry-picking changes from another banch label Jan 22, 2024
@yamilmedina yamilmedina self-assigned this Jan 22, 2024
@yamilmedina yamilmedina requested review from alexandreferris, a team, borichellow, MohamadJaara, Garzas and ohassine and removed request for a team January 22, 2024 13:16
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (0ecc5d4) 41.33% compared to head (ef455a6) 41.27%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2606      +/-   ##
=============================================
- Coverage      41.33%   41.27%   -0.07%     
  Complexity      1140     1140              
=============================================
  Files            365      365              
  Lines          13237    13257      +20     
  Branches        1749     1751       +2     
=============================================
  Hits            5472     5472              
- Misses          7238     7258      +20     
  Partials         527      527              
Files Coverage Δ
...me/messagecomposer/location/LocationPickerState.kt 0.00% <0.00%> (ø)
...essagecomposer/location/LocationPickerViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ecc5d4...ef455a6. Read the comment docs.

Copy link
Contributor

Test Results

750 tests  ±0   750 ✅ ±0   7m 27s ⏱️ - 3m 45s
105 suites ±0     0 💤 ±0 
105 files   ±0     0 ❌ ±0 

Results for commit ef455a6. ± Comparison against base commit 0ecc5d4.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2677 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina enabled auto-merge January 22, 2024 14:17
@yamilmedina yamilmedina added this pull request to the merge queue Jan 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Jan 23, 2024
Merged via the queue into develop with commit 9601c92 Jan 23, 2024
15 checks passed
@yamilmedina yamilmedina deleted the fix/location-runtime-denied-dev branch January 23, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants