-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changes to hopefully improve startup and ANRs [WPB-6048] #2611
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2611 +/- ##
=============================================
- Coverage 41.27% 41.22% -0.05%
Complexity 1140 1140
=============================================
Files 365 367 +2
Lines 13257 13272 +15
Branches 1751 1752 +1
=============================================
Hits 5472 5472
- Misses 7258 7273 +15
Partials 527 527
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2694 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2700 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
There is a most frequent ANR related to the
installSplashScreen
and happens when launching the app and the app startup on some devices can take even many seconds.Solutions
Number of small things that will hopefully speed up the launch and reduce number of ANRs or at least help us better investigate it:
onCreate
inWireApplication
andWireActivity
)Lazy
so that they are initialised only when needed not on the main threadTesting
How to Test
Launch the app.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.