fix: some end points are not routed through the proxy server #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results599 tests 598 ✅ 4m 0s ⏱️ Results for commit 13c8a17. ♻️ This comment has been updated with latest results. |
MohamadJaara
requested review from
yamilmedina,
vitorhugods,
saleniuk and
mchenani
saleniuk
approved these changes
Jan 26, 2024
app/src/main/kotlin/com/wire/android/ui/WireActivityViewModel.kt
Outdated
Show resolved
Hide resolved
yamilmedina
approved these changes
Jan 30, 2024
…y-mode-does-not-apply-to-all-api-points # Conflicts: # kalium
|
APKs built during tests are available here. Scroll down to Artifacts! |
MohamadJaara
deleted the
fix/proxy-mode-does-not-apply-to-all-api-points
branch
MohamadJaara
added a commit
that referenced
this pull request
Feb 12, 2024
(cherry picked from commit 702c402)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
some end points are not routed through the proxy server mainly the api version
Solutions
refactore the code so every thing is under the unauthenticated container and make sure is does have the proxy info passed correctly
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
run the app connet to wire server via socks proxy (message me if you need the setup) and in the network inspection only proxy link is used
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.