feat(e2ei): respect e2ei during login and mls client creation (WPB-5851) #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oaded into feat/e2ei/respect-e2ei-creating-mls-client
…oaded into feat/e2ei/respect-e2ei-creating-mls-client
…om:wireapp/wire-android-reloaded into feat/e2ei/respect-e2ei-creating-mls-client
…github.com/wireapp/wire-android-reloaded into feat/e2ei/respect-e2ei-creating-mls-client
…oaded into feat/e2ei/respect-e2ei-creating-mls-client # Conflicts: # kalium
…2ei/respect-e2ei-creating-mls-client-fixed-certificate-status
…oaded into feat/e2ei/respect-e2ei-creating-mls-client # Conflicts: # kalium
…#2606) Co-authored-by: Alexandre Ferris <[email protected]>
Co-authored-by: Yamil Medina <[email protected]>
|
Build 2723 failed. |
mchenani
commented
Jan 25, 2024
app/src/main/kotlin/com/wire/android/feature/e2ei/OAuthUseCase.kt
Outdated
Show resolved
Hide resolved
mchenani
commented
Jan 25, 2024
app/src/main/kotlin/com/wire/android/migration/feature/MigrateClientsDataUseCase.kt
Outdated
Show resolved
Hide resolved
mchenani
commented
Jan 25, 2024
...src/main/kotlin/com/wire/android/ui/authentication/create/code/CreateAccountCodeViewModel.kt
Outdated
Show resolved
Hide resolved
mchenani
commented
Jan 25, 2024
app/src/main/kotlin/com/wire/android/ui/settings/devices/e2ei/E2eiCertificateDetailsScreen.kt
Show resolved
Hide resolved
…oaded into feat/e2ei/respect-e2ei-creating-mls-client # Conflicts: # app/src/main/kotlin/com/wire/android/feature/e2ei/OAuthUseCase.kt # kalium
|
Build 2758 failed. |
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
…ndroid-reloaded into feat/e2ei/respect-e2ei-creating-mls-client # Conflicts: # app/src/main/kotlin/com/wire/android/ui/WireActivity.kt # app/src/main/res/drawable/ic_launcher_wire_logo.xml # app/src/main/res/values-af/strings.xml # app/src/main/res/values-ar/strings.xml # app/src/main/res/values-bn/strings.xml # app/src/main/res/values-ca/strings.xml # app/src/main/res/values-cs/strings.xml # app/src/main/res/values-da/strings.xml # app/src/main/res/values-de/strings.xml # app/src/main/res/values-el/strings.xml # app/src/main/res/values-es/strings.xml # app/src/main/res/values-et/strings.xml # app/src/main/res/values-fa/strings.xml # app/src/main/res/values-fi/strings.xml # app/src/main/res/values-fr/strings.xml # app/src/main/res/values-he/strings.xml # app/src/main/res/values-hi/strings.xml # app/src/main/res/values-hr/strings.xml # app/src/main/res/values-hu/strings.xml # app/src/main/res/values-id/strings.xml # app/src/main/res/values-it/strings.xml # app/src/main/res/values-ja/strings.xml # app/src/main/res/values-ko/strings.xml # app/src/main/res/values-lt/strings.xml # app/src/main/res/values-mk/strings.xml # app/src/main/res/values-nl/strings.xml # app/src/main/res/values-no/strings.xml # app/src/main/res/values-pa/strings.xml # app/src/main/res/values-pl/strings.xml # app/src/main/res/values-pt/strings.xml # app/src/main/res/values-ro/strings.xml # app/src/main/res/values-ru/strings.xml # app/src/main/res/values-si/strings.xml # app/src/main/res/values-sk/strings.xml # app/src/main/res/values-sl/strings.xml # app/src/main/res/values-sr/strings.xml # app/src/main/res/values-sv/strings.xml # app/src/main/res/values-tr/strings.xml # app/src/main/res/values-uk/strings.xml # app/src/main/res/values-vi/strings.xml # app/src/main/res/values-zh/strings.xml # app/src/test/kotlin/com/wire/android/ui/home/messagecomposer/location/LocationPickerViewModelTest.kt
|
Build 2760 failed. |
|
Build 2762 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2768 succeeded. The build produced the following APK's: |
borichellow
reviewed
Jan 26, 2024
borichellow
approved these changes
Jan 26, 2024
ohassine
reviewed
Jan 26, 2024
| @@ -25,6 +25,6 @@ object AndroidSdk { | |||
|
|
|||
| object AndroidApp { | |||
| const val id = "com.wire.android" | |||
| const val versionName = "4.6.0" | |||
| const val versionName = "4.7.0" | |||
There was a problem hiding this comment.
We shouldn't change the version
ohassine
approved these changes
Jan 26, 2024
7 tasks
echoes-hq
bot
added
the
echoes: technical-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Respecting E2EI state during MLS client registration and login.
Testing
Test Coverage (Optional)
WIP
How to Test
Have a team that has e2ei enabled, during login the user required to enroll certificate first.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.