Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setting items clickable area [WPB-6225] #2643

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jan 30, 2024

BugWPB-6225 [Android] Enable the entire space of settings entries clickable


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Settings item's chevron icon prevents clicking on the item, icon takes over the click action and nothing happens then.

Solutions

Make icons not clickable when not needed to be (so that it's not always a button but regular non-clickable icon).

Testing

How to Test

Open settings and try to click on the chevron icon.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, alexandreferris, MohamadJaara and Garzas and removed request for a team January 30, 2024 14:52
Copy link
Contributor

Test Results

753 tests   753 ✅  13m 6s ⏱️
106 suites    0 💤
106 files      0 ❌

Results for commit dadbd52.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2801 succeeded.

The build produced the following APK's:

@saleniuk saleniuk merged commit 42c5830 into release/candidate Jan 31, 2024
15 checks passed
@saleniuk saleniuk deleted the fix/settings-items-clickable-area branch January 31, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants