Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logging level does not reflect in datadog #2645

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 31, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Currently, we are not being able to see correct level of severity in Datadog dashboards for internal builds

Causes (Optional)

Datadog, does not inform about anomalies spikes automatically. Also, we can not categorize by error level, since now everything is debug and info.

Solutions

Use a similar approach that Kermit uses for their Logcat implementation.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

See logs on datadog, and should see them with colorful statuses 🟥 🟨 🟦 for each logged messages.

Attachments (Optional)

Before:
Screenshot 2024-01-31 at 11 56 31
Screenshot 2024-01-31 at 11 56 38


After:
Screenshot 2024-01-31 at 11 47 12

Insights autogenerated
Screenshot 2024-01-31 at 12 03 59


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested a review from saleniuk January 31, 2024 11:02
@yamilmedina yamilmedina requested review from a team, typfel, alexandreferris and Garzas and removed request for a team January 31, 2024 11:02
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👌🏻

@yamilmedina yamilmedina enabled auto-merge (squash) January 31, 2024 11:19
@yamilmedina yamilmedina merged commit 51c465e into release/candidate Jan 31, 2024
19 of 20 checks passed
@yamilmedina yamilmedina deleted the fix/datadog-logging-level branch January 31, 2024 11:22
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2806 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants