chore(tests): support vintage engine (junit4) and add robolectric (ACOL-139) #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamilmedina
requested review from
alexandreferris,
vitorhugods,
mchenani,
ohassine and
saleniuk
and removed request for
a team
yamilmedina
changed the title
|
Build 2880 failed. |
yamilmedina
commented
Feb 5, 2024
| @@ -48,7 +48,7 @@ class UserTypeMapperTest { | |||
| @Test | |||
| fun `given internal as a user type correctly map to none as membership`() { | |||
| val result = userTypeMapper.toMembership(UserType.INTERNAL) | |||
| assertEquals(Membership.None, result) | |||
| assertEquals(Membership.Standard, result) | |||
There was a problem hiding this comment.
These class tests were not running, since the annotations were junit4, being skipped.
Now is running with this PR and this particular check was broken.
|
Build 2882 failed. |
...m/wire/android/ui/home/conversations/details/editguestaccess/EditGuestAccessViewModelTest.kt
Outdated
Show resolved
Hide resolved
yamilmedina
commented
Feb 6, 2024
| @@ -174,7 +174,11 @@ class EditGuestAccessViewModel @Inject constructor( | |||
| ) | |||
| ) | |||
|
|
|||
| is UpdateConversationAccessRoleUseCase.Result.Success -> Unit | |||
| is UpdateConversationAccessRoleUseCase.Result.Success -> updateState( | |||
There was a problem hiding this comment.
After fixing the ignored tests, this test was failing, because we were not explicitly updating the State in the success case. Test caught this unexpected behavior in a TDD-like fashion
yamilmedina
changed the title
|
Build 2896 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2898 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2922 failed. |
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We want to increase the code covereage, so to do so we can add tests with robolectric to cover more cases
Causes (Optional)
Decided in the android collective.
Solutions
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.