Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: divider thickness [WPB-3985] 🍒 #2973

Merged
merged 2 commits into from
May 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 6, 2024

BugWPB-3985 [Android] Divider lines are missing in conversation details / options view

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Fixed default thickness for WireDivider

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
divider_before divider_after

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels May 6, 2024
@AndroidBob
Copy link
Collaborator

Build 4619 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara enabled auto-merge May 6, 2024 23:46
@MohamadJaara MohamadJaara added this pull request to the merge queue May 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.34%. Comparing base (df97d3d) to head (af5cf6a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2973      +/-   ##
===========================================
+ Coverage    44.19%   44.34%   +0.14%     
===========================================
  Files          444      444              
  Lines        14476    14477       +1     
  Branches      2489     2490       +1     
===========================================
+ Hits          6398     6420      +22     
+ Misses        7387     7358      -29     
- Partials       691      699       +8     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df97d3d...af5cf6a. Read the comment docs.

Copy link
Contributor Author

github-actions bot commented May 7, 2024

Test Results

927 tests  ±0   927 ✅ ±0   11m 12s ⏱️ + 2m 20s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit af5cf6a. ± Comparison against base commit df97d3d.

Copy link
Contributor Author

github-actions bot commented May 7, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit bf5d34e May 7, 2024
11 of 12 checks passed
@MohamadJaara MohamadJaara deleted the fix/divider-thickness-cherry-pick branch May 7, 2024 00:29
@AndroidBob
Copy link
Collaborator

Build 4640 succeeded.

The build produced the following APK's:

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants