Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert launch mode to singleTask (WPB-9014) 🍒 #2978

Merged
merged 2 commits into from
May 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 6, 2024

BugWPB-9014 [Android] A second instance of the app to be started when clicking on a deep link

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

A second instance of the app to be started when clicking on a deep link

Solutions

Change launch mode to single instance for WireActivity

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels May 6, 2024
@AndroidBob
Copy link
Collaborator

Build 4631 succeeded.

The build produced the following APK's:

@ohassine ohassine requested a review from alexandreferris May 7, 2024 06:23
@ohassine ohassine enabled auto-merge May 7, 2024 08:33
@ohassine ohassine added this pull request to the merge queue May 7, 2024
Copy link
Contributor Author

github-actions bot commented May 7, 2024

Test Results

927 tests  ±0   927 ✅ ±0   16m 52s ⏱️ + 8m 54s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit 9ec5860. ± Comparison against base commit bf5d34e.

Copy link
Contributor Author

github-actions bot commented May 7, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit eb02dc3 May 7, 2024
11 of 12 checks passed
@ohassine ohassine deleted the revert-launch-mode-to-singleInstance-cherry-pick branch May 7, 2024 09:27
@AndroidBob
Copy link
Collaborator

Build 4645 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants