fix: multiple undo tap for drawing, unnecessary recompositions (WPB-8810) 🍒

[github-actions]

WPB-8810 [Android] Sketcher Undo button works on 3rd tap

This PR was automatically cherry-picked based on the following PR:

• fix: multiple undo tap for drawing, unnecessary recompositions (WPB-8810) #3032

Original PR description:

---

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

We are doing unnecessary recompositions, and we are not using immutable lists.

Causes (Optional)

Sometimes, we need to tap the undo button many times for the same line.

Solutions

Make use of immutable collections, and mark state as stable too, to help the compiler.
Add tests coverage for this case.

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Draw lines and see if it is necessary to tap many undos.

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.29%. Comparing base (ac4c4a2) to head (dfd5905).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3033      +/-   ##
===========================================
+ Coverage    44.26%   44.29%   +0.02%     
===========================================
  Files          448      448              
  Lines        14517    14519       +2     
  Branches      2493     2493              
===========================================
+ Hits          6426     6431       +5     
+ Misses        7389     7385       -4     
- Partials       702      703       +1     

Files	Coverage Δ
...e/android/feature/sketch/DrawingCanvasViewModel.kt	55.17% <100.00%> (+6.04%)	⬆️
...roid/feature/sketch/model/DrawingPathProperties.kt	9.09% <100.00%> (ø)
.../wire/android/feature/sketch/model/DrawingState.kt	100.00% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac4c4a2...dfd5905. Read the comment docs.

[github-actions]

Test Results

931 tests  +1   931 ✅ +1   13m 29s ⏱️ +35s
124 suites ±0     0 💤 ±0 
124 files   ±0     0 ❌ ±0 

Results for commit dfd5905. ± Comparison against base commit ac4c4a2.

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 4973 succeeded.

The build produced the following APK's:

• com.wire.android-v4.8.0(9757428)(9757428)-staging-compat.apk