fix: interaction during screen transitions [WPB-6533] #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results857 tests 857 ✅ 13m 34s ⏱️ Results for commit 02d742a. ♻️ This comment has been updated with latest results. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
…into fix/clicks-during-screen-transition
saleniuk
requested review from
a team,
typfel,
yamilmedina,
alexandreferris,
borichellow and
vitorhugods
and removed request for
a team
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
alexandreferris
approved these changes
Jul 12, 2024
Yes, it only applies to screen transitions (composables that are marked with |
This was referenced Jul 12, 2024
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
The user can click on a screen during the transition, for instance when the screen is being closed, it's still clickable so if user clicks during closing, it can still open something from the previous screen and end up on a different screen than user wanted.
Causes (Optional)
The screen during transition is still clickable and can interact until it's fully hidden.
Solutions
Create a wrapper
WaitUntilTransitionEndsWrapperfor the destination composables so that it covers the entire screen and intercepts any click. This cover is added to the screen only when the transition is ongoing, at the moment the transition ends, this cover is removed from the screen so that it's fully clickable.Created new annotation
@WireDestinationwhich replaces@Destinationand contains this wrapper by default.Testing
How to Test
Navigate in the app and try to quickly click on the screen that's being open or closed.
Attachments (Optional)
Transition animations were slowed down to 2s in videos below.
before.mp4
after.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.