Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in a system message (WPB-9776) #3212

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Jul 22, 2024

TaskWPB-9776 [GitHub Action] Update translation


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Typo with this system message
"1 person was removed form the team"

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the base branch from develop to release/candidate July 22, 2024 07:40
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@ohassine ohassine requested review from a team, typfel, borichellow, MohamadJaara, vitorhugods and saleniuk and removed request for a team July 22, 2024 07:40
@ohassine ohassine changed the title fix: typo in system messages fix: typo in a system message Jul 22, 2024
@ohassine ohassine added this pull request to the merge queue Jul 22, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3212.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3212.apk is available for download

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 22, 2024
@yamilmedina yamilmedina changed the title fix: typo in a system message fix: typo in a system message (WPB-9776) Jul 22, 2024
Copy link
Contributor

Built wire-android-staging-release-pr-3212.apk is available for download

Copy link
Contributor

Built wire-android-internal-compat-pr-3212.apk is available for download

@yamilmedina yamilmedina enabled auto-merge July 22, 2024 20:52
Copy link

@yamilmedina yamilmedina added this pull request to the merge queue Jul 22, 2024
Merged via the queue into release/candidate with commit 9762d28 Jul 22, 2024
10 of 12 checks passed
@yamilmedina yamilmedina deleted the typo-fix branch July 22, 2024 21:51
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants