fix: block sending empty messages, also empty markdowns [WPB-10179] 🍒 #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
|
Built wire-android-staging-compat-pr-3232.apk is available for download |
|
Built wire-android-dev-debug-pr-3232.apk is available for download |
saleniuk
requested review from
a team,
yamilmedina,
borichellow,
vitorhugods,
mchenani and
saleniuk
and removed request for
a team
alexandreferris
approved these changes
Jul 26, 2024
|
|
Built wire-android-staging-compat-pr-3232.apk is available for download |
|
Built wire-android-dev-debug-pr-3232.apk is available for download |
saleniuk
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We can send empty messages, spaces or breaking lines in the conversations.
Causes (Optional)
isNotEmpty()used instead ofisNotBlank(), but that still does not block the user from sending messages with empty markdowns, like#.Solutions
Check if the message that the user writes is not blank and is not "markdown blank" which means it doesn't contain any markdown with actual text. It uses our markdown helper so it should behave exactly the same as showing the message, messages that would appear empty will be blocked from being sent.
Testing
Test Coverage (Optional)
How to Test
Enter message with only whitespaces or with markdowns containing only whitespaces and try to send that message - .
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.