fix: multiline topbar title not centered [WPB-9608] #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix/multiline-topbar-title-not-centered
saleniuk
requested review from
a team,
typfel,
yamilmedina,
MohamadJaara,
Garzas and
ohassine
and removed request for
a team
|
Built wire-android-staging-release-pr-3239.apk is available for download |
|
Built wire-android-internal-compat-pr-3239.apk is available for download |
yamilmedina
approved these changes
Jul 29, 2024
|
alexandreferris
approved these changes
Jul 29, 2024
|
Built wire-android-staging-compat-pr-3239.apk is available for download |
|
Built wire-android-internal-compat-pr-3239.apk is available for download |
6 tasks
echoes-hq
bot
added
the
echoes: unplanned
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Top bar title is not centered when it has two lines of text.
Causes (Optional)
There's an ongoing issue about multiline text taking all width available instead of wrapping visible text.
https://issuetracker.google.com/issues/206039942
Solutions
This workaround is based on this: https://stackoverflow.com/a/69947555, but instead of using
SubcomposeLayout, we just first measure the text, check the length of each line of text, choose the longest and set it as the width of theTextcomposable.Testing
How to Test
Open the screen where title takes more than one line of text, usually device details where device name is long enough to take two lines.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.