Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: audio converting error on lower APIs [WPB-11242] 🍒 #3469

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 25, 2024

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-11242 [Android] Crash on Android 9 when sending recorded audio


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

On Android 9, the app is crashing when sending a recorded audio.

Causes (Optional)

Crash due to out of order frames.

Solutions

Change the way presentationTimeUs is calculated, it looks like starting from some value different than 0 is error-prone, so make sure that it starts with 0. Returning success to not send faulty file if something wrong happened during the conversion.

Testing

How to Test

It was crashing on device with Android 9 when clicking "send" after user finished recording audio message.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels Sep 25, 2024
@saleniuk saleniuk requested review from a team, typfel, alexandreferris, mchenani, Garzas and mathias-niboulies and removed request for a team September 25, 2024 11:46
Copy link

@saleniuk saleniuk enabled auto-merge September 25, 2024 11:51
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 44.74%. Comparing base (d7c8bc9) to head (c459f19).
Report is 68 commits behind head on develop.

Files with missing lines Patch % Lines
.../messagecomposer/recordaudio/AudioMediaRecorder.kt 0.00% 28 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3469      +/-   ##
===========================================
- Coverage    44.78%   44.74%   -0.04%     
===========================================
  Files          466      466              
  Lines        15703    15715      +12     
  Branches      2646     2648       +2     
===========================================
  Hits          7032     7032              
- Misses        7914     7926      +12     
  Partials       757      757              
Files with missing lines Coverage Δ
.../messagecomposer/recordaudio/AudioMediaRecorder.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c8bc9...c459f19. Read the comment docs.

Copy link
Contributor Author

Built wire-android-staging-compat-pr-3469.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3469.apk is available for download

@saleniuk saleniuk added this pull request to the merge queue Sep 25, 2024
Merged via the queue into develop with commit 59131de Sep 25, 2024
12 checks passed
@saleniuk saleniuk deleted the fix/record-audio-storage-error-cherry-pick branch September 25, 2024 12:56
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants