Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Audio message play in background WPB-11725 #3766

Merged
merged 37 commits into from
Jan 23, 2025

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 23, 2024

StoryWPB-11725 [Android] Playback improvement - 2 - Auto playback/Background play

this is the first PR from 2, next is coming soon and will be merged into this branch.

What's new in this PR?

  1. Audio message could be played even when user leave conversation screen
  2. When audio message ended the next audio message in conversation (if exist) starts automatically, without any actions from user side
  3. Audio control buttons in ConversationItem in ConversationsList screen.

Attachments (Optional)

Screenshot 2024-12-23 at 12 25 04

@borichellow borichellow self-assigned this Dec 23, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 37.68844% with 248 lines in your changes missing coverage. Please review.

Project coverage is 45.46%. Comparing base (400baca) to head (b48337e).

Files with missing lines Patch % Lines
...dia/audiomessage/ConversationAudioMessagePlayer.kt 56.74% 70 Missing and 7 partials ⚠️
...ire/android/services/PlayingAudioMessageService.kt 0.00% 68 Missing ⚠️
...ire/android/media/audiomessage/AudioFocusHelper.kt 0.00% 19 Missing ⚠️
.../com/wire/android/media/audiomessage/AudioState.kt 53.12% 15 Missing ⚠️
...in/com/wire/android/notification/PendingIntents.kt 0.00% 12 Missing ⚠️
...ndroid/notification/NotificationChannelsManager.kt 0.00% 11 Missing ⚠️
...ome/conversationslist/ConversationListViewModel.kt 35.71% 9 Missing ⚠️
...tlin/com/wire/android/mapper/ConversationMapper.kt 41.66% 6 Missing and 1 partial ⚠️
...otlin/com/wire/android/services/ServicesManager.kt 50.00% 7 Missing ⚠️
...roadcastreceivers/PlayPauseAudioMessageReceiver.kt 14.28% 6 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3766      +/-   ##
===========================================
- Coverage    45.79%   45.46%   -0.33%     
===========================================
  Files          486      490       +4     
  Lines        16643    16882     +239     
  Branches      2798     2832      +34     
===========================================
+ Hits          7622     7676      +54     
- Misses        8239     8421     +182     
- Partials       782      785       +3     
Files with missing lines Coverage Δ
...rsations/messages/ConversationMessagesViewState.kt 100.00% <100.00%> (ø)
...tions/usecase/GetConversationsFromSearchUseCase.kt 81.48% <75.00%> (+0.71%) ⬆️
...essagecomposer/recordaudio/RecordAudioViewModel.kt 64.58% <0.00%> (ø)
...wire/android/notification/NotificationConstants.kt 10.52% <0.00%> (-0.59%) ⬇️
...rsations/messages/ConversationMessagesViewModel.kt 68.75% <70.00%> (-1.43%) ⬇️
...i/home/conversationslist/model/ConversationItem.kt 54.54% <33.33%> (-1.56%) ⬇️
...roadcastreceivers/PlayPauseAudioMessageReceiver.kt 14.28% <14.28%> (ø)
...ion/broadcastreceivers/StopAudioMessageReceiver.kt 14.28% <14.28%> (ø)
...tlin/com/wire/android/mapper/ConversationMapper.kt 64.54% <41.66%> (-3.46%) ⬇️
...otlin/com/wire/android/services/ServicesManager.kt 68.08% <50.00%> (-6.34%) ⬇️
... and 7 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400baca...b48337e. Read the comment docs.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Built wire-android-staging-compat-pr-3766.apk is available for download

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Built wire-android-dev-debug-pr-3766.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3766.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3766.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3766.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3766.apk is available for download

@borichellow borichellow enabled auto-merge January 21, 2025 14:25
Copy link
Contributor

Built wire-android-staging-compat-pr-3766.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3766.apk is available for download

@borichellow borichellow added this pull request to the merge queue Jan 23, 2025
Copy link
Contributor

Built wire-android-staging-compat-pr-3766.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3766.apk is available for download

Merged via the queue into develop with commit 59d4513 Jan 23, 2025
12 of 13 checks passed
@borichellow borichellow deleted the feat/audio_messages_play_in_background branch January 23, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants