Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Delete group option on Leaving it WPB-14938 #3809

Merged
merged 10 commits into from
Jan 23, 2025

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Jan 20, 2025

TaskWPB-14938 [Android] Add "Delete group and content on all devices" option when leaving a group

What's new in this PR?

Added check-box to fully delete the group when user is leaving the conversation.

Attachments (Optional)

Screenshot 2025-01-20 at 12 55 24

Need to merge with wireapp/kalium#3235

@borichellow borichellow self-assigned this Jan 20, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 20, 2025
Copy link
Contributor

Built wire-android-staging-compat-pr-3809.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3809.apk is available for download

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 45.43%. Comparing base (59d4513) to head (c1e21c9).

Files with missing lines Patch % Lines
...tions/details/GroupConversationDetailsViewModel.kt 16.66% 13 Missing and 2 partials ⚠️
...ome/conversationslist/ConversationListViewModel.kt 0.00% 4 Missing ⚠️
...i/home/conversationslist/model/GroupDialogState.kt 42.85% 4 Missing ⚠️
...ome/conversationslist/ConversationsDialogsState.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3809      +/-   ##
===========================================
- Coverage    45.48%   45.43%   -0.05%     
===========================================
  Files          490      490              
  Lines        16879    16895      +16     
  Branches      2828     2833       +5     
===========================================
  Hits          7677     7677              
- Misses        8417     8432      +15     
- Partials       785      786       +1     
Files with missing lines Coverage Δ
...ome/conversationslist/ConversationsDialogsState.kt 0.00% <0.00%> (ø)
...ome/conversationslist/ConversationListViewModel.kt 33.21% <0.00%> (-0.24%) ⬇️
...i/home/conversationslist/model/GroupDialogState.kt 69.23% <42.85%> (-30.77%) ⬇️
...tions/details/GroupConversationDetailsViewModel.kt 64.28% <16.66%> (-3.46%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d4513...c1e21c9. Read the comment docs.

@borichellow borichellow enabled auto-merge January 23, 2025 16:10
@borichellow borichellow added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
Copy link
Contributor

Built wire-android-staging-compat-pr-3809.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3809.apk is available for download

@borichellow borichellow added this pull request to the merge queue Jan 23, 2025
Merged via the queue into develop with commit fffb999 Jan 23, 2025
13 of 14 checks passed
@borichellow borichellow deleted the feat/delete_group_option_on_leaving_it branch January 23, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants