Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Send btn not shown on closed keyboard WPB-15247 #3814

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Jan 21, 2025

BugWPB-15247 [Android] Send button not shown when user closes keyboard after typing a message


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Send button not shown when user closes keyboard after typing a message

Causes (Optional)

small mistake in ifs

Solutions

check if message can be sent while showing send btn and if so - show it no meter what is the state.

Attachments (Optional)

Screenshot 2025-01-21 at 12 43 36

@borichellow borichellow self-assigned this Jan 21, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 21, 2025
Copy link
Contributor

Built wire-android-staging-compat-pr-3814.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3814.apk is available for download

@borichellow borichellow added this pull request to the merge queue Jan 21, 2025
Merged via the queue into develop with commit 199160b Jan 21, 2025
13 of 14 checks passed
@borichellow borichellow deleted the fix/send_btn_not_shown_on_closed_keyboard branch January 21, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants