Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scrollable folders filter [WPB-15474] #3819

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: scrollable folders filter [WPB-15474] #3819

merged 1 commit into from
Jan 23, 2025

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jan 23, 2025 •
edited by github-actions bot
Loading

TaskWPB-15474 [Android] When user has many folders, list is not scrollable on android

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • added scrollable modifier to folders filter to be able to scroll them when there are more folders than screen size

@Garzas Garzas self-assigned this Jan 23, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jan 23, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Garzas Garzas enabled auto-merge January 23, 2025 08:53
@Garzas Garzas added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3819.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3819.apk is available for download

@Garzas Garzas added this pull request to the merge queue Jan 23, 2025
Merged via the queue into develop with commit fec53a6 Jan 23, 2025
13 of 14 checks passed
@Garzas Garzas deleted the fix/scrollable-folders-filter branch January 23, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

Assignees

@Garzas Garzas

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Garzas @yamilmedina @saleniuk