fix: wrong error after adding folder [WPB-15478] #3820
Merged
+35
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: product-roadmap
|
yamilmedina
approved these changes
Jan 23, 2025
| ) | ||
| if (!folderNameState.loading) { | ||
| folderNameState = folderNameState.copy( | ||
| buttonEnabled = text.trim().isNotEmpty() && !nameExist && text.length <= NAME_MAX_COUNT, |
There was a problem hiding this comment.
Suggested change
| buttonEnabled = text.trim().isNotEmpty() && !nameExist && text.length <= NAME_MAX_COUNT, | |
| buttonEnabled = text.trim().isNotEmpty() && !nameExists && text.length <= NAME_MAX_COUNT, |
saleniuk
approved these changes
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3820 +/- ##
===========================================
+ Coverage 45.78% 45.79% +0.01%
===========================================
Files 486 486
Lines 16638 16643 +5
Branches 2797 2798 +1
===========================================
+ Hits 7617 7622 +5
Misses 8239 8239
Partials 782 782
Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3820.apk is available for download |
|
Built wire-android-dev-debug-pr-3820.apk is available for download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
After successfully added folder there was short period of showing error that folder name already exist. It's caused because current folder list is propagating new folder before screen closes
Solutions
Disable updating folders state by checking progress state