Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added more logs in import media screen [WPB-15656] #3821

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jan 23, 2025

BugWPB-15656 [Android] Send button remains greyed out when sharing screen recording to chat


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Added more logs to get insight why sometimes assets are not loaded in import media screen

@Garzas Garzas self-assigned this Jan 23, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 23, 2025
@Garzas Garzas enabled auto-merge January 23, 2025 11:58
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 45.81%. Comparing base (400baca) to head (38013e4).

Files with missing lines Patch % Lines
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 10.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3821      +/-   ##
===========================================
+ Coverage    45.79%   45.81%   +0.01%     
===========================================
  Files          486      486              
  Lines        16643    16640       -3     
  Branches      2798     2794       -4     
===========================================
+ Hits          7622     7623       +1     
+ Misses        8239     8235       -4     
  Partials       782      782              
Files with missing lines Coverage Δ
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 34.65% <10.00%> (+1.96%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400baca...38013e4. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3821.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3821.apk is available for download

@Garzas Garzas added this pull request to the merge queue Jan 23, 2025
Merged via the queue into develop with commit 9afc756 Jan 23, 2025
12 of 13 checks passed
@Garzas Garzas deleted the chore/import-media-logs branch January 23, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants