Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Blue dot at the end of progress #WPB-14575 #3822

Closed
wants to merge 38 commits into from

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Jan 23, 2025

BugWPB-14575 [Android] Blue dot displayed on restoring backup progress bar

What's new in this PR?

Issues

There is an unnecessary blue dot displayed in the restoring backup progress bar (actually on any progress bar in app).

Causes (Optional)

drawStopIndicator in LinearProgressIndicator that we are using in WireLinearProgressIndicator draws this dot.

Solutions

set drawStopIndicator to empty lambda, to draw nothing at the end of progress bar.

Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 23, 2025
@borichellow borichellow deleted the fix/blue_dot_at_the_end_of_progress branch January 23, 2025 13:48
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 37.68844% with 248 lines in your changes missing coverage. Please review.

Project coverage is 45.46%. Comparing base (400baca) to head (75df18a).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...dia/audiomessage/ConversationAudioMessagePlayer.kt 56.74% 70 Missing and 7 partials ⚠️
...ire/android/services/PlayingAudioMessageService.kt 0.00% 68 Missing ⚠️
...ire/android/media/audiomessage/AudioFocusHelper.kt 0.00% 19 Missing ⚠️
.../com/wire/android/media/audiomessage/AudioState.kt 53.12% 15 Missing ⚠️
...in/com/wire/android/notification/PendingIntents.kt 0.00% 12 Missing ⚠️
...ndroid/notification/NotificationChannelsManager.kt 0.00% 11 Missing ⚠️
...ome/conversationslist/ConversationListViewModel.kt 35.71% 9 Missing ⚠️
...tlin/com/wire/android/mapper/ConversationMapper.kt 41.66% 6 Missing and 1 partial ⚠️
...otlin/com/wire/android/services/ServicesManager.kt 50.00% 7 Missing ⚠️
...roadcastreceivers/PlayPauseAudioMessageReceiver.kt 14.28% 6 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3822      +/-   ##
===========================================
- Coverage    45.79%   45.46%   -0.33%     
===========================================
  Files          486      490       +4     
  Lines        16643    16882     +239     
  Branches      2798     2832      +34     
===========================================
+ Hits          7622     7676      +54     
- Misses        8239     8421     +182     
- Partials       782      785       +3     
Files with missing lines Coverage Δ
...rsations/messages/ConversationMessagesViewState.kt 100.00% <100.00%> (ø)
...tions/usecase/GetConversationsFromSearchUseCase.kt 81.48% <75.00%> (+0.71%) ⬆️
...essagecomposer/recordaudio/RecordAudioViewModel.kt 64.58% <0.00%> (ø)
...wire/android/notification/NotificationConstants.kt 10.52% <0.00%> (-0.59%) ⬇️
...rsations/messages/ConversationMessagesViewModel.kt 68.75% <70.00%> (-1.43%) ⬇️
...i/home/conversationslist/model/ConversationItem.kt 54.54% <33.33%> (-1.56%) ⬇️
...roadcastreceivers/PlayPauseAudioMessageReceiver.kt 14.28% <14.28%> (ø)
...ion/broadcastreceivers/StopAudioMessageReceiver.kt 14.28% <14.28%> (ø)
...tlin/com/wire/android/mapper/ConversationMapper.kt 64.54% <41.66%> (-3.46%) ⬇️
...otlin/com/wire/android/services/ServicesManager.kt 68.08% <50.00%> (-6.34%) ⬇️
... and 7 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400baca...75df18a. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3822.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3822.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants