-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Blue dot at the end of progress #WPB-14575 #3822
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ireapp/wire-android-reloaded into feat/audio_messages_play_in_background
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
echoes-hq
bot
added
the
echoes: product-roadmap/bug
Work contributing to resolve a bug not critical enough to have raised an incident.
label
Jan 23, 2025
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3822.apk is available for download |
Built wire-android-dev-debug-pr-3822.apk is available for download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DO NOT MERGE
echoes: product-roadmap/bug
Work contributing to resolve a bug not critical enough to have raised an incident.
size/XL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
There is an unnecessary blue dot displayed in the restoring backup progress bar (actually on any progress bar in app).
Causes (Optional)
drawStopIndicator
inLinearProgressIndicator
that we are using inWireLinearProgressIndicator
draws this dot.Solutions
set
drawStopIndicator
to empty lambda, to draw nothing at the end of progress bar.