fix: Blue dot at the end of progress #WPB-14575 #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
sbakhtiarov,
yamilmedina,
Garzas and
saleniuk
echoes-hq
bot
added
the
echoes: product-roadmap/bug
|
saleniuk
approved these changes
Jan 23, 2025
|
Built wire-android-staging-compat-pr-3823.apk is available for download |
|
Built wire-android-dev-debug-pr-3823.apk is available for download |
yamilmedina
approved these changes
Jan 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
There is an unnecessary blue dot displayed in the restoring backup progress bar (actually on any progress bar in app).
Causes (Optional)
drawStopIndicatorinLinearProgressIndicatorthat we are using inWireLinearProgressIndicatordraws this dot.Solutions
set
drawStopIndicatorto empty lambda, to draw nothing at the end of progress bar.