-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new enterprise login validations for initial screen (WPB-15520) #3824
base: epic/new-sso-login-flow
Are you sure you want to change the base?
feat: new enterprise login validations for initial screen (WPB-15520) #3824
Conversation
97ef946
to
b4c23f9
Compare
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
New ADR(s) in this PR 📚:5. Simplified enterprise loginDate: 2025-01-23 StatusAccepted ContextStarting (potentially) from Android 4.12.x the app will support the new enterprise login flows, this means in practice that the app needs to support both flows current/old. The current flow (old)Customers configure their setup manually in their backend. The new flowCustomers, via team settings and Back-office tools, will be able to load this config to facilitate the decision of which flow the user must use. This will make the app, in conjunction with the backend, decide for the user which path/flow they must use to login by just having one input field, “email or SSO code”. DecisionWe will keep both flows, the current as-is and the new one, being the app able to decide which one to use based on the configuration received from the backend. %%{
init: {
'theme': 'neutral'
}
}%%
flowchart LR
z((App loads</br> BE/API context)) --> di
di{BE supports </br>API >= 8 ?}:::someclass -- Yes --> a1
di -- No</br>OR Authenticated Proxy --> b1
classDef someclass fill:#f96
subgraph new_flow
a0@{ shape: braces, label: "These flows are selected by the app and the BE" }
a1[StartLoginScreen </br>'Enter email or SSO code'] -- looks like SSO code --> a2[Go to SSO flow path 6-7]
a1 -- Looks like an email? --> a3[BE replies which path to go 1-4]
end
subgraph current_flow
b0@{ shape: braces, label: "These flows are selected manually by the user" }
b1[WelcomeScreen] --> b2[LoginEmailScreen]
b1 --> b3[LoginWithSSOCodeScreen]
end
Consequences
|
Quality Gate passedIssues Measures |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
We need to provide initial validation for the email and SSO code input, later this will decide some part of the flows to follow.
Dependencies (Optional)
Needs releases with:
Testing
Will add test coverage.
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.