Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enter password and proxy details screen [WPB-14338] #3825

Open
wants to merge 11 commits into
base: epic/new-sso-login-flow
Choose a base branch
from

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jan 23, 2025

TaskWPB-14338 [Android] - Implement UI paths 1 & 2


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Implemented NewLoginPasswordScreen as a second step of the new enterprise login flow (path 1 & 2) together with proxy inputs (path 5 & 8 with proxy). Reused as many elements from current flow as it was possible, only ProxyContent and CreateAccountContent had to be created from scratch as they look different. Updated NewLoginContainer to be scrollable when the content is too tall and added new NewLoginHeader that uses NavigationIconButton.

Attachments (Optional)

newloginpasswordscreen


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…re-flag' into feat/newlogin-password-screen-ui

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/newauthentication/login/NewLoginScreen.kt
…flow' into feat/newlogin-password-screen-ui

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/authentication/welcome/WelcomeScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/newauthentication/login/NewLoginScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/newauthentication/login/password/NewLoginPasswordScreen.kt
@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Jan 23, 2025
@saleniuk saleniuk requested a review from yamilmedina January 23, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: scale Enterprise Readiness Initiatives size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant