Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: proper use of gradle cache #3898

Draft
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

yamilmedina
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.55%. Comparing base (e338311) to head (1f18def).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3898      +/-   ##
===========================================
- Coverage    45.56%   45.55%   -0.02%     
===========================================
  Files          491      491              
  Lines        17064    17068       +4     
  Branches      2846     2845       -1     
===========================================
  Hits          7776     7776              
- Misses        8495     8499       +4     
  Partials       793      793              
Files with missing lines Coverage Δ
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 18.75% <0.00%> (+0.08%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e338311...1f18def. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Built wire-android-staging-compat-pr-3898.apk is available for download

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Built wire-android-dev-debug-pr-3898.apk is available for download

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Built wire-android-staging-compat-pr-3898.apk is available for download

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Built wire-android-dev-debug-pr-3898.apk is available for download

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Built wire-android-staging-compat-pr-3898.apk is available for download

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Built wire-android-dev-debug-pr-3898.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3898.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3898.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants