feat: use entered email for old flow when new is not supported [WPB-16058] #3905
+55
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Pass email when navigating to the old login flow when the app uses server config that doesn't support v8 so that the user won't have to enter it twice. It's done by returning email in
EnterpriseLoginNotSupported
action and then passing it as a navigation parameter.LoginNavArgs.userHandle
was changed to becomePreFilledUserIdentifierType.PreFilled
and a new fieldeditable
was added to that class so that it can be decided when navigating whether email field should be enabled for editing or pre-filled without the option to edit it.Testing
Test Coverage (Optional)
How to Test
Use the deep link to switch backend to the one that doesn't yet support enterprise login and v8 (staging for instance) and with the
login-type=new
parameter. It should make it so that when you try to log in, the app will returnEnterpriseLoginNotSupported
because it's not supported on this backend yet, so it should navigate to the old flow with email field already filled in but also able to be edited.Attachments (Optional)
newlogin_not_supported.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.