chore(deps): bump fs-extra and @types/fs-extra #5781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
javascript
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/fs-extra-and-types/fs-extra-11.2.0
branch
8 times, most recently
from
218d09c to
747c86a
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/fs-extra-and-types/fs-extra-11.2.0
branch
2 times, most recently
from
c74f7a7 to
0a53235
Compare
|
svitovyda
force-pushed
the
dependabot/npm_and_yarn/fs-extra-and-types/fs-extra-11.2.0
branch
from
0a53235 to
c13ccd0
Compare
svitovyda
force-pushed
the
dependabot/npm_and_yarn/fs-extra-and-types/fs-extra-11.2.0
branch
2 times, most recently
from
764b12f to
45efead
Compare
tlebon
reviewed
May 21, 2024
| if (typeof entity === 'object') { | ||
| newEntity = JSON.stringify(entity); | ||
| } | ||
| const newEntity: string = JSON.stringify(entity); |
There was a problem hiding this comment.
i dont see a reason to make this change personally.
There was a problem hiding this comment.
it will lead to a quoted string in the unhappy path. we should use the previous method instead i believe. unless there is something im missing
tlebon
suggested changes
May 21, 2024
tlebon
reviewed
May 21, 2024
| if (typeof entity === 'object') { | ||
| newEntity = JSON.stringify(entity); | ||
| } | ||
| const newEntity: string = JSON.stringify(entity); |
There was a problem hiding this comment.
Suggested change
| const newEntity: string = JSON.stringify(entity); | |
| let newEntity: string; | |
| if (typeof entity === 'object') { | |
| newEntity = JSON.stringify(entity); | |
| }else{ | |
| newEntity = entity; | |
| } |
perhaps this works?
There was a problem hiding this comment.
I'd shorten it to
const newEntity: string = typeof entity === 'object' ? JSON.stringify(entity) : entity;
but also, maybe ... : entity.toString()?
Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra) and [@types/fs-extra](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/fs-extra). These dependencies needed to be updated together. Updates `fs-extra` from 11.1.0 to 11.2.0 - [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md) - [Commits](jprichardson/node-fs-extra@11.1.0...11.2.0) Updates `@types/fs-extra` from 9.0.13 to 11.0.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/fs-extra) --- updated-dependencies: - dependency-name: fs-extra dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: "@types/fs-extra" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
svitovyda
force-pushed
the
dependabot/npm_and_yarn/fs-extra-and-types/fs-extra-11.2.0
branch
from
7cf1bbb to
ea4f2f3
Compare
…lculated to fix the types
svitovyda
force-pushed
the
dependabot/npm_and_yarn/fs-extra-and-types/fs-extra-11.2.0
branch
from
ea4f2f3 to
1366d7e
Compare
|
svitovyda
deleted the
dependabot/npm_and_yarn/fs-extra-and-types/fs-extra-11.2.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps fs-extra and @types/fs-extra. These dependencies needed to be updated together.
Updates
fs-extrafrom 11.1.0 to 11.2.0Changelog
Sourced from fs-extra's changelog.
Commits
5d4bf0b11.2.0d293448perf: copy dir contents in parallel (#1026)a277cbbRefactormoveAPI to async/await (#1025)40c5161RefactorcopyAPI to async/await (#1021)6f2b2bcRefactorcreate*/ensure*API to async/await (#1023)426bb46RefactoroutputFileAPI to async/await (#1024)47bc43dSimplify reduce for checking match (#1016)cc7b3b211.1.1055e0b8Unify cross-device move test configuration/logic (#1001)0e7de32Preserve timestamp when moving across devices (#994)Updates
@types/fs-extrafrom 9.0.13 to 11.0.4Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)