feat: fetch local certificate root [WPB-3338] #5863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweiss-dev
approved these changes
Jan 12, 2024
| }; | ||
|
|
||
| constructor(private discoveryUrl: string) {} | ||
|
|
||
| private get acmeBaseUrl() { | ||
| const hostname = new URL(this.discoveryUrl).hostname; | ||
| return `https://${hostname}`; |
There was a problem hiding this comment.
You can get the protocol from
The url as well
PatrykBuniX
force-pushed
the
feat/WPB-3338-fetch-local-root-cert
branch
from
2dc2168 to
4913bb2
Compare
PatrykBuniX
force-pushed
the
feat/WPB-3338-fetch-local-root-cert
branch
from
3b4094c to
d69feb6
Compare
aweiss-dev
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the first enrolment, we need to fetch the local root certificate and pass it to core-crypto for it to be validated.
This should be done only once.