fix(e2ei): skip upload of MLSPublicKeys for existing clients #5880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykBuniX
approved these changes
Jan 19, 2024
aweiss-dev
changed the title
przemvs
reviewed
Jan 19, 2024
Comment on lines
+816
to
+818
| if (typeof client.mls_public_keys.ed25519 !== 'string' || client.mls_public_keys.ed25519.length === 0) { | ||
| // Renewals do not need to upload new public keys | ||
| if (!hasActiveCertificate) { |
There was a problem hiding this comment.
Suggested change
| if (typeof client.mls_public_keys.ed25519 !== 'string' || client.mls_public_keys.ed25519.length === 0) { | |
| // Renewals do not need to upload new public keys | |
| if (!hasActiveCertificate) { | |
| if ((typeof client.mls_public_keys.ed25519 !== 'string' || client.mls_public_keys.ed25519.length === 0) && !hasActiveCertificate) { |
Can't be like that ?
atomrc
reviewed
Jan 22, 2024
| // we only upload public keys for the initial certification process. Renewals do not need to upload new public keys | ||
| await this.uploadMLSPublicKeys(client); | ||
| // We only upload public keys for the initial certification process AND if they dont exist already. | ||
| if (typeof client.mls_public_keys.ed25519 !== 'string' || client.mls_public_keys.ed25519.length === 0) { |
There was a problem hiding this comment.
I think we have a util somewhere that does exactly that 🤔 Isn't it?
|
superseeded by #5972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.