Adding useJUnitPlatform() #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oleg-nenashev / @tomakehurst Please check this out - Because of this change and the fact that the tests are actually now executing, some of the tests fail and need to be fixed. I don't know how to fix them, but they were never actually being executed before. |
|
This test is failing, but only on windows with Java 11: This test was introduced by #31 and apparently doesn't work correctly in some situations. |
This was referenced Dec 19, 2023
edeandrea
commented
Dec 19, 2023
| @@ -63,7 +63,7 @@ public GrpcResponseDefinitionBuilder withTemplatingEnabled(boolean enabled) { | |||
|
|
|||
| public GrpcResponseDefinitionBuilder withFixedDelay(long milliseconds) { | |||
| this.delay = new FixedDelayDistribution(milliseconds); | |||
| return null; | |||
| return this; | |||
There was a problem hiding this comment.
I brought in #35 to this PR
|
It seems #35 will fix this |
|
Thanks! |
edeandrea
added a commit
to edeandrea/wiremock-grpc-extension
that referenced
this pull request
Dec 19, 2023
* Adding useJUnitPlatform() * GrpcResponseDefinitionBuilder.withFixedDelay returning null instead of this
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
useJUnitPlatform()to theteststanza. As it stands, the unit tests are never actually being executed, including in your GitHub Actions CI/CD process.