Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify mappings status in WireMock test container on startup and fail by default when there're no mappings #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oleg-nenashev
Copy link
Member

This is an alternative to #69 for #28 that uses the Wait Strategy to verify the response and say the container is not ready if there are no mappings. Unfortunately it is not going help with #28, bacause there is no way to abort the wait loop from the predicate.

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@oleg-nenashev oleg-nenashev added the enhancement New feature or request label Aug 21, 2023
@bitxon
Copy link
Contributor

bitxon commented Aug 26, 2023

I like the idea to have validation of empty mapping, but i would allow empty mapping by default and failed container only if developer explicitly asked about that (executed withFailureOnEmptyMappings())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants