Naive fix for TextLayout TopLeft #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change doesn't make sense to me. Why is it centering the text when that's what the TEXT_ALIGN is supposed to do? |
The TextLayout draws from the top left. Normal Text objects center like that, but TextLayout is a box that contains text, so centering it would center at the center of the box, which is drawn top left by default currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes TextLayout centered like boxes.
This should not bother people who are using
egpDrawTopLeft(1)by default. I hope. This will bother people who expected old behavior.Todo: This sucks because
MoveTopLeftundoes what this does. Maybe make MoveTopLeft a method, too?Change default rendering to topleft by default? Maybe save that for EGPv4 (it's really annoying, though).