Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aimEntity bug #2894

Closed
wants to merge 1 commit into from
Closed

Fix aimEntity bug #2894

wants to merge 1 commit into from

Conversation

Sandalot
Copy link
Contributor

Previously did not return the world entity as the world is considered an invalid entity.

Previously did not return the world entity as the world is considered an invalid entity.
@Divran
Copy link
Contributor

Divran commented Nov 23, 2023

This will probably break old E2s for not much gain. This function has worked that way for so long, it'd introduce unexpected behavior to change it now.

Also, you can already get the aim entity even if it's the world if you switch to using Ply:eyeTraceNoCursor():entity() instead of Ply:aimEntity() which won't have much, if any, performance impact since they do the same thing under the hood

edit: also it's not a bug

@Sandalot
Copy link
Contributor Author

Fair enough, didn't know that Ply:eyeTraceNoCursor() was available.

@Sandalot Sandalot closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants