Vector cleanups #2895
Merged
Vector cleanups #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vurv78
suggested changes
Nov 23, 2023
Vurv78
approved these changes
Nov 23, 2023
thegrb93
reviewed
Nov 23, 2023
Comment on lines
+417
to
+422
| e2function vector min(vector vec1, vector vec2) | ||
| return vec1:LengthSqr() < vec2:LengthSqr() and vec1 or vec2 | ||
| end | ||
|
|
||
| e2function vector max(vector rv1, vector rv2) | ||
| local length1 = ( rv1[1] * rv1[1] + rv1[2] * rv1[2] + rv1[3] * rv1[3] ) ^ 0.5 | ||
| local length2 = ( rv2[1] * rv2[1] + rv2[2] * rv2[2] + rv2[3] * rv2[3] ) ^ 0.5 | ||
| if length1 > length2 then return rv1 else return rv2 end | ||
| e2function vector max(vector vec1, vector vec2) | ||
| return vec1:LengthSqr() > vec2:LengthSqr() and vec1 or vec2 |
There was a problem hiding this comment.
These functions are really stupid. Why don't they max/min the components? Is there a different function that does that?
There was a problem hiding this comment.
Yes, maxVec declared right below this
There was a problem hiding this comment.
Why would you even need that?
There was a problem hiding this comment.
I could see uses for both.
This comment was marked as resolved.
This comment was marked as resolved.
Quit bitching, your server is 3 months outdated. (I do appreciate you at least doing this on github, though) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lerp(vector, vector, number)minandmaxto use square magnitude insteadvector:toAnglerandVecto useVector.Randommixto be more descriptivemixto useLerpVectorANGLE_ZEROconstant to use preexistingangle_zeroconstantFixes #2893